mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-05 14:55:08 +00:00
refactor(web): read plugins through a PluginCatalog; only the display runs them (#688)
The web process built its own PluginManager and loaded plugins into itself: store installs and updates loaded or reloaded a web-side copy, and config saves and enable/disable called on_config_change, on_enable and on_disable on it. None of that reached the panel, and /plugins/installed reported runtime state from those copies. - Add PluginCatalog (src/plugin_system/plugin_catalog.py): manifests, directories, display modes, installed version, schema and config reads, with no way to run a plugin. app.py and both blueprints use it; the plugin_manager blueprint attribute is gone. - Remove every lifecycle call from the web routes. Config changes already reach the display through ConfigService (on_config_change) and the enabled-set reconcile. - Health and metrics readers move to api_v3.health_tracker / resource_monitor. /plugins/installed reports loaded/state/error_info as null (the display does not publish them) and enabled by the display's rule. - Store install, update and uninstall answer restart_required when the running display will not pick the change up by itself (display_restart_required). The restart banner follows the flag via window.noteRestartRequired instead of the /config/main URL heuristic; /config/main now sends restart_required: true. - The one remaining in-process import of plugin code (Starlark helper modules, oauth_flow action scripts) goes through _import_plugin_code_in_web_process() until a web-entry contract. - /plugins/installed reports vegas_participation (from #682) from the user's setting or the manifest, with vegas_participation_source; when only the plugin's code decides it, null with source 'runtime', since the web process no longer has plugin instances to ask. - Check & Update All keeps its restart flags when the final list refresh fails, and asks for a restart when an enabled plugin's first request got no answer and the re-sent one found it up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -142,6 +142,40 @@ read any of them:
|
||||
on the store card and linked to the plugin's source at that commit.
|
||||
Informational only; installs still come from the branch head.
|
||||
|
||||
### Changes
|
||||
|
||||
- The web interface no longer loads or runs plugins (web plugin catalog,
|
||||
stage 1). It built its own `PluginManager` and loaded plugins into the web
|
||||
process: store installs and updates loaded or reloaded a web-side copy, and
|
||||
config saves and enable/disable called `on_config_change`, `on_enable` and
|
||||
`on_disable` on it. None of that reached the panel. The web process now
|
||||
reads plugins as files through the new `PluginCatalog`
|
||||
(`src/plugin_system/plugin_catalog.py`); only the display runs them, and
|
||||
config changes reach them through its config watcher, as they already did.
|
||||
- A plugin update, an install of a plugin that is already enabled, or an
|
||||
uninstall that keeps an enabled plugin's config now answers
|
||||
`restart_required: true` and shows the restart banner, because the
|
||||
running display keeps the code it loaded until it restarts. Before, the
|
||||
update looked applied and the panel kept the old version.
|
||||
- The restart banner follows `restart_required` in any response
|
||||
(`POST /api/v3/config/main` sends it) rather than the URL that was
|
||||
called.
|
||||
- `/api/v3/plugins/installed` reports `loaded`, `state` and `error_info`
|
||||
as `null`: the display does not publish them, and the old values
|
||||
described web-side copies. `enabled` follows the display's rule, so a
|
||||
plugin whose config has no `enabled` flag shows as disabled (it never
|
||||
ran). `vegas_mode` is the configured value only.
|
||||
- `vegas_participation` there is the user's setting, else the manifest's
|
||||
declaration, with a new `vegas_participation_source` (`config` or
|
||||
`manifest`). When only the plugin's code decides it (a
|
||||
`get_vegas_participation()` override or the legacy Vegas hooks) it is
|
||||
`null` with source `runtime`: the display derives it, and the web no
|
||||
longer asks a web-side plugin instance.
|
||||
- Starlark routes always use their on-disk path. The one place the web
|
||||
process still imports plugin code -- the Starlark helper modules and an
|
||||
`oauth_flow` action script -- is `_import_plugin_code_in_web_process()`,
|
||||
until a plugin web-entry contract replaces it.
|
||||
|
||||
### Fixes
|
||||
|
||||
- Reinstalling a plugin by its registry id when it is installed under its
|
||||
|
||||
Reference in New Issue
Block a user