Fix ncaafb ranking display (#45)

* Fix NCAAFB ranking display issue

- Remove duplicate ranking system that was drawing rankings behind team logos
- Old system (_get_rank) was drawing rankings at top of logos
- New system (_fetch_team_rankings) correctly draws rankings in bottom corners
- Remove old ranking calls from live, recent, and upcoming game drawing functions
- Remove unnecessary _fetch_rankings() calls from update methods
- Rankings now only appear in designated corner positions, not overlapping logos

Fixes issue where team rankings/betting lines were being drawn behind
team logos instead of replacing team records in the corners.

* Add missing show_ranking and show_records options to NCAAFB web UI

- Add show_ranking option to NCAAFB scoreboard config template
- Add show_records and show_ranking toggle switches to NCAAFB web UI
- Update JavaScript form collection to include new fields
- Users can now control whether to show team records or rankings via web interface

This completes the fix for NCAAFB ranking display - users can now enable
show_ranking in the web UI to see AP Top 25 rankings instead of team records.
This commit is contained in:
Chuck
2025-09-17 14:46:57 -04:00
committed by GitHub
parent 379e2c3714
commit 6fcc93cab8
3 changed files with 27 additions and 62 deletions

View File

@@ -1277,6 +1277,26 @@
</div>
<div class="description">Only display games involving your favorite teams</div>
</div>
<div class="form-group">
<label for="ncaa_fb_show_records">Show Team Records:</label>
<div class="toggle-container">
<label class="toggle-switch">
<input type="checkbox" id="ncaa_fb_show_records" name="ncaa_fb_show_records" {% if main_config.ncaa_fb_scoreboard.show_records %}checked{% endif %}>
<span class="slider"></span>
</label>
</div>
<div class="description">Display team win-loss records in bottom corners</div>
</div>
<div class="form-group">
<label for="ncaa_fb_show_ranking">Show Team Rankings:</label>
<div class="toggle-container">
<label class="toggle-switch">
<input type="checkbox" id="ncaa_fb_show_ranking" name="ncaa_fb_show_ranking" {% if main_config.ncaa_fb_scoreboard.show_ranking %}checked{% endif %}>
<span class="slider"></span>
</label>
</div>
<div class="description">Display AP Top 25 rankings instead of records for ranked teams</div>
</div>
</div>
<div class="config-section">
@@ -2894,7 +2914,9 @@
live_priority: document.getElementById('ncaa_fb_live_priority').checked,
live_game_duration: parseInt(document.getElementById('ncaa_fb_live_game_duration').value),
show_odds: document.getElementById('ncaa_fb_show_odds').checked,
show_favorite_teams_only: document.getElementById('ncaa_fb_show_favorite_teams_only').checked
show_favorite_teams_only: document.getElementById('ncaa_fb_show_favorite_teams_only').checked,
show_records: document.getElementById('ncaa_fb_show_records').checked,
show_ranking: document.getElementById('ncaa_fb_show_ranking').checked
},
ncaa_baseball_scoreboard: {
enabled: document.getElementById('ncaa_baseball_enabled').checked,