rick/LEDMatrix
1
0
Fork 0
mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-05-01 13:03:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugins): use cached store on HTMX re-swap; reserve searchPluginStore(true) for first load

Browse Source 
searchPluginStore(true) bypasses the isCacheValid check unconditionally,
so every tab revisit was hitting the GitHub commit-info API even within
the 5-minute cache window.

Set window.pluginManager._reswap = true in the htmx:afterSwap handler
and read it in initializePlugins() to call searchPluginStore(false) on
re-swaps (respects the 5-minute cache) vs searchPluginStore(true) on
first load (always fetches fresh). Explicit user refresh via
refreshPlugins() already calls searchPluginStore(true) directly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Chuck
2026-04-30 11:52:35 -04:00
parent 9a7c008b90
commit 5ae800492f
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
web_interface/static/v3/plugins_manager.js
View File

@@ -1168,6 +1168,7 @@ function initializePluginPageWhenReady() {
// Reset all initialization flags so the fresh empty DOM gets populated // Reset all initialization flags so the fresh empty DOM gets populated
window.pluginManager.initialized = false; window.pluginManager.initialized = false;
window.pluginManager.initializing = false; window.pluginManager.initializing = false;
window.pluginManager._reswap = true; // signal: use cached store, don't re-fetch GitHub
pluginsInitialized = false; pluginsInitialized = false;
initTimer = setTimeout(attemptInit, 100); initTimer = setTimeout(attemptInit, 100);
} }
@@ -1212,9 +1213,13 @@ function initializePlugins() {
console.warn('[INIT] checkGitHubAuthStatus not available yet'); console.warn('[INIT] checkGitHubAuthStatus not available yet');
} }
// Load both installed plugins and plugin store // Load both installed plugins and plugin store.
// On HTMX re-swaps use cached store data (fetchCommitInfo=false) to avoid
// re-hitting GitHub on every tab switch; only fetch fresh on first load.
const isReswap = !!window.pluginManager._reswap;
window.pluginManager._reswap = false;
loadInstalledPlugins(); loadInstalledPlugins();
searchPluginStore(true); // Load plugin store with fresh metadata from GitHub searchPluginStore(!isReswap);
// Setup search functionality (with guard against duplicate listeners) // Setup search functionality (with guard against duplicate listeners)
const searchInput = document.getElementById('plugin-search'); const searchInput = document.getElementById('plugin-search');