rick/LEDMatrix
1
0
Fork 0
mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-10-05 06:45:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(display): schedule windows end at the end time; on-demand ending in off hours blanks at once (#714)

Browse Source 
Schedule and dim windows are half-open [start, end): on from the start time, off at exactly the end time, whatever second the check runs. An on-demand session that ends in scheduled-off hours (expiry or stop) clears the once-a-minute schedule gate, so the panel blanks within about a second. Golden: schedule; two test_display_pending_changes.py tests now say end_time 23:00.

Merged with #712 and #713: with all three in, docs/RUN_LOOP_REDESIGN.md's 'may be wrong' list is empty, so that section now records that all six items are fixed and by which PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Chuck
2026-10-01 16:10:04 -04:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 77e0ea91ae
commit 41db488c73
9 changed files with 265 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/fixtures/run_loop_golden/schedule.json
Vendored
+5 -9
View File
@@ -4,14 +4,10 @@
[20.0, "weather", 20.0, "duration", 20, true],
[40.0, "clock", 20.0, "duration", 20, true],
[60.0, "weather", 20.0, "duration", 20, true],
[80.0, "clock", 20.0, "duration", 20, true],
[100.0, "weather", 20.0, "duration", 20, true],
[120.0, "clock", 20.0, "duration", 20, true],
[140.0, "weather", 10.0, "schedule-off", 11, true],
[150.0, "<off>", 20.0, "on-demand-start", 2, null],
[80.0, "clock", 10.0, "schedule-off", 11, true],
[90.0, "<off>", 80.0, "on-demand-start", 3, null],
[170.0, "weather", 20.0, "on-demand-expired", 20, true],
[190.0, "weather", 20.0, "schedule-off", 20, true],
[210.0, "<off>", 120.0, "schedule-on", 2, null],
[190.0, "<off>", 140.0, "schedule-on", 3, null],
[330.0, "clock", 20.0, "duration", 20, true],
[350.0, "weather", 20.0, "duration", 20, true],
[370.0, "clock", 20.0, "duration", 20, true],
@@ -19,13 +15,13 @@
],
"events": [
[30.0, "brightness", 30],
[150.0, "schedule-off"],
[90.0, "schedule-off"],
[170.0, "request", "start:s1"],
[170.0, "on-demand-start", "weather"],
[170.0, "schedule-on"],
[170.0, "brightness", 90],
[190.0, "on-demand-expired"],
[210.0, "schedule-off"],
[190.0, "schedule-off"],
[330.0, "schedule-on"]
]
}