Add light/dark mode toggle and fix log readability (#243)

* feat(web): add light/dark mode toggle and fix log readability

Add a theme toggle button (moon/sun icon) to the header that switches
between light and dark mode. Theme preference persists in localStorage
and falls back to the OS prefers-color-scheme setting.

The implementation uses a data-theme attribute on <html> with CSS
overrides, so all 13 partial templates and 20+ widget JS files get
dark mode support without any modifications — only 3 files changed.

Also fixes log timestamp readability: text-gray-500 had ~3.5:1 contrast
ratio against the dark log background, now uses text-gray-400 (~5.3:1)
which passes WCAG AA in both light and dark mode.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(web): address dark mode review — accessibility, robustness, and code quality

- WCAG touch target: enforce 44×44px minimum on theme toggle button
  with display:inline-flex centering
- Accessibility: add type="button", aria-pressed (dynamically updated),
  aria-hidden on decorative icons, and contextual aria-label/title that
  reflects current state ("Switch to light/dark mode")
- Robustness: wrap all localStorage and matchMedia calls in try/catch
  with fallbacks for private browsing and restricted contexts; use
  addListener fallback for older browsers lacking addEventListener
- Stylelint: convert all rgba() to modern rgb(…/…%) notation across
  both light and dark theme shadows and gradients
- DRY: replace hardcoded hex values in dark mode utility overrides and
  component overrides with CSS variable references (--color-surface,
  --color-background, --color-border, --color-text-primary, etc.)
- Remove redundant [data-theme="dark"] body rule (body already uses
  CSS variables that are redefined under the dark theme selector)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Chuck <chuck@example.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Chuck
2026-02-12 21:12:37 -05:00
committed by GitHub
parent 158e07c82b
commit 3975940cff
3 changed files with 308 additions and 12 deletions

View File

@@ -26,12 +26,62 @@
--color-info-bg: #dbeafe; --color-info-bg: #dbeafe;
--color-purple-bg: #f3e8ff; --color-purple-bg: #f3e8ff;
--color-purple-text: #6b21a8; --color-purple-text: #6b21a8;
--shadow-sm: 0 1px 2px 0 rgba(0, 0, 0, 0.05); --shadow-sm: 0 1px 2px 0 rgb(0 0 0 / 5%);
--shadow: 0 1px 3px 0 rgba(0, 0, 0, 0.1), 0 1px 2px 0 rgba(0, 0, 0, 0.06); --shadow: 0 1px 3px 0 rgb(0 0 0 / 10%), 0 1px 2px 0 rgb(0 0 0 / 6%);
--shadow-md: 0 4px 6px -1px rgba(0, 0, 0, 0.1), 0 2px 4px -1px rgba(0, 0, 0, 0.06); --shadow-md: 0 4px 6px -1px rgb(0 0 0 / 10%), 0 2px 4px -1px rgb(0 0 0 / 6%);
--shadow-lg: 0 10px 15px -3px rgba(0, 0, 0, 0.1), 0 4px 6px -2px rgba(0, 0, 0, 0.05); --shadow-lg: 0 10px 15px -3px rgb(0 0 0 / 10%), 0 4px 6px -2px rgb(0 0 0 / 5%);
} }
/* Dark Theme Overrides */
[data-theme="dark"] {
--color-primary: #3b82f6;
--color-primary-hover: #60a5fa;
--color-secondary: #10b981;
--color-secondary-hover: #34d399;
--color-accent: #8b5cf6;
--color-accent-hover: #a78bfa;
--color-background: #111827;
--color-surface: #1f2937;
--color-text-primary: #f9fafb;
--color-text-secondary: #d1d5db;
--color-text-tertiary: #9ca3af;
--color-border: #374151;
--color-border-light: #1f2937;
--color-success: #34d399;
--color-success-bg: #064e3b;
--color-error: #f87171;
--color-error-bg: #7f1d1d;
--color-warning: #fbbf24;
--color-warning-bg: #78350f;
--color-info: #60a5fa;
--color-info-bg: #1e3a5f;
--color-purple-bg: #2e1065;
--color-purple-text: #c4b5fd;
--shadow-sm: 0 1px 2px 0 rgb(0 0 0 / 30%);
--shadow: 0 1px 3px 0 rgb(0 0 0 / 40%), 0 1px 2px 0 rgb(0 0 0 / 30%);
--shadow-md: 0 4px 6px -1px rgb(0 0 0 / 40%), 0 2px 4px -1px rgb(0 0 0 / 30%);
--shadow-lg: 0 10px 15px -3px rgb(0 0 0 / 40%), 0 4px 6px -2px rgb(0 0 0 / 30%);
}
/* Dark Mode - Utility Class Overrides */
[data-theme="dark"] .bg-white { background-color: var(--color-surface); }
[data-theme="dark"] .bg-gray-50 { background-color: var(--color-background); }
[data-theme="dark"] .bg-gray-200 { background-color: var(--color-border); }
[data-theme="dark"] .text-gray-900 { color: var(--color-text-primary); }
[data-theme="dark"] .text-gray-600 { color: var(--color-text-tertiary); }
[data-theme="dark"] .text-gray-500 { color: var(--color-text-tertiary); }
[data-theme="dark"] .text-gray-400 { color: var(--color-text-tertiary); }
[data-theme="dark"] .text-green-600 { color: var(--color-success); }
[data-theme="dark"] .text-red-600 { color: var(--color-error); }
[data-theme="dark"] .border-gray-200 { border-color: var(--color-border); }
[data-theme="dark"] .border-gray-300 { border-color: #4b5563; }
[data-theme="dark"] .hover\:bg-gray-50:hover { background-color: var(--color-border); }
[data-theme="dark"] .hover\:text-gray-700:hover { color: #e5e7eb; }
[data-theme="dark"] .hover\:border-gray-300:hover { border-color: #6b7280; }
/* Base styles */ /* Base styles */
* { * {
box-sizing: border-box; box-sizing: border-box;
@@ -422,7 +472,7 @@ a, button, input, select, textarea {
.btn:focus { .btn:focus {
outline: 2px solid transparent; outline: 2px solid transparent;
outline-offset: 2px; outline-offset: 2px;
box-shadow: 0 0 0 3px rgba(37, 99, 235, 0.3); box-shadow: 0 0 0 3px rgb(37 99 235 / 30%);
} }
/* Global button text contrast fix: Ensure buttons with white backgrounds have dark text */ /* Global button text contrast fix: Ensure buttons with white backgrounds have dark text */
@@ -460,7 +510,7 @@ button.bg-white {
.form-control:focus { .form-control:focus {
border-color: var(--color-primary); border-color: var(--color-primary);
/* Using outline instead of box-shadow for focus state (better performance) */ /* Using outline instead of box-shadow for focus state (better performance) */
outline: 2px solid rgba(37, 99, 235, 0.2); outline: 2px solid rgb(37 99 235 / 20%);
outline-offset: 2px; outline-offset: 2px;
} }
@@ -599,7 +649,7 @@ button.bg-white {
/* Section Headers with Subtle Gradients */ /* Section Headers with Subtle Gradients */
.section-header { .section-header {
background: linear-gradient(135deg, rgba(255, 255, 255, 0.9) 0%, rgba(249, 250, 251, 0.9) 100%); background: linear-gradient(135deg, rgb(255 255 255 / 90%) 0%, rgb(249 250 251 / 90%) 100%);
border-bottom: 1px solid var(--color-border); border-bottom: 1px solid var(--color-border);
padding: 1rem 0; padding: 1rem 0;
margin-bottom: 1.5rem; margin-bottom: 1.5rem;
@@ -634,7 +684,7 @@ button.bg-white {
/* Enhanced Modal Styling */ /* Enhanced Modal Styling */
.modal-backdrop { .modal-backdrop {
background-color: rgba(0, 0, 0, 0.5); background-color: rgb(0 0 0 / 50%);
/* Removed backdrop-filter: blur() for better performance on Raspberry Pi */ /* Removed backdrop-filter: blur() for better performance on Raspberry Pi */
transition: opacity 0.2s ease; transition: opacity 0.2s ease;
} }
@@ -731,8 +781,8 @@ button.bg-white {
font-weight: 600; font-weight: 600;
border-bottom-width: 3px; border-bottom-width: 3px;
border-bottom-color: #2563eb; /* border-blue-600 */ border-bottom-color: #2563eb; /* border-blue-600 */
background: linear-gradient(135deg, rgba(37, 99, 235, 0.1) 0%, rgba(59, 130, 246, 0.05) 100%); background: linear-gradient(135deg, rgb(37 99 235 / 10%) 0%, rgb(59 130 246 / 5%) 100%);
box-shadow: 0 2px 4px rgba(37, 99, 235, 0.1); box-shadow: 0 2px 4px rgb(37 99 235 / 10%);
} }
.nav-tab-active i { .nav-tab-active i {
@@ -753,3 +803,157 @@ button.bg-white {
padding-right: 0.75rem; padding-right: 0.75rem;
} }
} }
/* ==========================================================
Dark Mode - Component Overrides
========================================================== */
/* Header */
[data-theme="dark"] header {
background-color: var(--color-surface);
border-color: var(--color-border);
}
/* Form controls */
[data-theme="dark"] .form-control {
background-color: var(--color-border);
color: var(--color-text-primary);
border-color: #4b5563;
}
[data-theme="dark"] .form-control:focus {
border-color: var(--color-primary);
outline-color: rgb(59 130 246 / 30%);
}
[data-theme="dark"] .form-control:disabled {
background-color: var(--color-surface);
}
/* Buttons with bg-white */
[data-theme="dark"] button.bg-white {
background-color: var(--color-border) !important;
color: var(--color-text-primary) !important;
}
/* Nav tabs */
[data-theme="dark"] .nav-tab:not(.nav-tab-active) {
color: var(--color-text-secondary);
}
[data-theme="dark"] .nav-tab:not(.nav-tab-active) i {
color: var(--color-text-secondary);
}
[data-theme="dark"] .nav-tab:not(.nav-tab-active):hover {
color: var(--color-text-primary);
background-color: var(--color-border);
border-bottom-color: #6b7280;
}
[data-theme="dark"] .nav-tab:not(.nav-tab-active):hover i {
color: var(--color-text-primary);
}
[data-theme="dark"] .nav-tab-active {
color: #93c5fd;
border-bottom-color: #3b82f6;
background: linear-gradient(135deg, rgb(59 130 246 / 15%) 0%, rgb(59 130 246 / 5%) 100%);
}
[data-theme="dark"] .nav-tab-active i {
color: #93c5fd;
}
/* Section header */
[data-theme="dark"] .section-header {
background: linear-gradient(135deg, rgb(31 41 55 / 90%) 0%, rgb(17 24 39 / 90%) 100%);
}
/* Status indicators */
[data-theme="dark"] .status-indicator.success {
background-color: #064e3b;
color: #6ee7b7;
}
[data-theme="dark"] .status-indicator.error {
background-color: #7f1d1d;
color: #fca5a5;
}
[data-theme="dark"] .status-indicator.warning {
background-color: #78350f;
color: #fcd34d;
}
/* Skeleton loading */
[data-theme="dark"] .skeleton {
background-color: var(--color-border);
}
/* Scrollbar */
[data-theme="dark"] ::-webkit-scrollbar-track {
background: var(--color-surface);
}
[data-theme="dark"] ::-webkit-scrollbar-thumb {
background: #4b5563;
}
[data-theme="dark"] ::-webkit-scrollbar-thumb:hover {
background: #6b7280;
}
/* Log panel - slightly deeper than surface for contrast */
[data-theme="dark"] #logs-container {
background-color: #0f1623;
border-color: var(--color-border);
}
[data-theme="dark"] #logs-display,
[data-theme="dark"] #logs-loading,
[data-theme="dark"] #logs-empty {
background-color: #0f1623;
}
/* Warning/info boxes used in various partials */
[data-theme="dark"] .bg-yellow-50 { background-color: #422006; }
[data-theme="dark"] .border-yellow-200 { border-color: #78350f; }
[data-theme="dark"] .text-yellow-800 { color: #fcd34d; }
[data-theme="dark"] .text-yellow-700 { color: #fbbf24; }
[data-theme="dark"] .text-yellow-600 { color: #fbbf24; }
[data-theme="dark"] .bg-blue-50 { background-color: #1e3a5f; }
[data-theme="dark"] .border-blue-200 { border-color: #1e40af; }
[data-theme="dark"] .text-blue-800 { color: #93c5fd; }
[data-theme="dark"] .text-blue-700 { color: #93c5fd; }
[data-theme="dark"] .bg-red-50 { background-color: #450a0a; }
[data-theme="dark"] .border-red-200 { border-color: #7f1d1d; }
[data-theme="dark"] .text-red-800 { color: #fca5a5; }
[data-theme="dark"] .text-red-700 { color: #fca5a5; }
[data-theme="dark"] .bg-green-50 { background-color: #022c22; }
[data-theme="dark"] .border-green-200 { border-color: #064e3b; }
[data-theme="dark"] .text-green-800 { color: #6ee7b7; }
[data-theme="dark"] .text-green-700 { color: #6ee7b7; }
/* Theme toggle button */
.theme-toggle-btn {
display: inline-flex;
align-items: center;
justify-content: center;
min-width: 44px;
min-height: 44px;
font-size: 1.1rem;
line-height: 1;
cursor: pointer;
border: none;
background: transparent;
color: #4b5563;
}
.theme-toggle-btn:hover {
opacity: 0.8;
}
[data-theme="dark"] .theme-toggle-btn {
color: #fbbf24;
}

View File

@@ -5,6 +5,86 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0"> <meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>LED Matrix Control Panel - v3</title> <title>LED Matrix Control Panel - v3</title>
<!-- Theme initialization (must run before CSS to prevent flash) -->
<script>
(function() {
// Safely read from localStorage (may throw in private browsing / restricted contexts)
function getStorage(key) {
try { return localStorage.getItem(key); } catch (e) { return null; }
}
function setStorage(key, value) {
try { localStorage.setItem(key, value); } catch (e) { /* no-op */ }
}
// Safely query prefers-color-scheme (matchMedia may be unavailable)
function prefersDark() {
try {
return window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches;
} catch (e) { return false; }
}
var saved = getStorage('theme');
var theme = saved || (prefersDark() ? 'dark' : 'light');
document.documentElement.setAttribute('data-theme', theme);
// Theme toggle function
window.toggleTheme = function() {
try {
var current = document.documentElement.getAttribute('data-theme');
var next = current === 'dark' ? 'light' : 'dark';
document.documentElement.setAttribute('data-theme', next);
setStorage('theme', next);
window.updateThemeIcon(next);
} catch (e) { /* no-op */ }
};
// Update icon visibility and ARIA state based on current theme
window.updateThemeIcon = function(theme) {
var darkIcon = document.getElementById('theme-icon-dark');
var lightIcon = document.getElementById('theme-icon-light');
var btn = document.getElementById('theme-toggle');
if (darkIcon && lightIcon) {
if (theme === 'dark') {
darkIcon.classList.add('hidden');
lightIcon.classList.remove('hidden');
} else {
darkIcon.classList.remove('hidden');
lightIcon.classList.add('hidden');
}
}
if (btn) {
var isDark = theme === 'dark';
btn.setAttribute('aria-pressed', String(isDark));
var label = isDark ? 'Switch to light mode' : 'Switch to dark mode';
btn.setAttribute('aria-label', label);
btn.setAttribute('title', label);
}
};
// Initialize icon state once DOM is ready
document.addEventListener('DOMContentLoaded', function() {
window.updateThemeIcon(document.documentElement.getAttribute('data-theme') || 'light');
});
// Listen for OS theme changes (only when no explicit user preference)
try {
var mql = window.matchMedia('(prefers-color-scheme: dark)');
var handler = function(e) {
if (!getStorage('theme')) {
var t = e.matches ? 'dark' : 'light';
document.documentElement.setAttribute('data-theme', t);
window.updateThemeIcon(t);
}
};
if (mql.addEventListener) {
mql.addEventListener('change', handler);
} else if (mql.addListener) {
mql.addListener(handler);
}
} catch (e) { /* matchMedia unavailable */ }
})();
</script>
<!-- Resource hints for CDN resources --> <!-- Resource hints for CDN resources -->
<link rel="preconnect" href="https://unpkg.com" crossorigin> <link rel="preconnect" href="https://unpkg.com" crossorigin>
<link rel="preconnect" href="https://cdnjs.cloudflare.com" crossorigin> <link rel="preconnect" href="https://cdnjs.cloudflare.com" crossorigin>
@@ -1309,8 +1389,20 @@
</h1> </h1>
</div> </div>
<!-- Connection status --> <!-- Connection status and theme toggle -->
<div class="flex items-center space-x-4"> <div class="flex items-center space-x-4">
<!-- Theme toggle -->
<button id="theme-toggle"
type="button"
onclick="toggleTheme()"
class="theme-toggle-btn p-2 rounded-md"
title="Switch to dark mode"
aria-label="Switch to dark mode"
aria-pressed="false">
<i class="fas fa-moon" id="theme-icon-dark" aria-hidden="true"></i>
<i class="fas fa-sun hidden" id="theme-icon-light" aria-hidden="true"></i>
</button>
<div id="connection-status" class="flex items-center space-x-2 text-sm"> <div id="connection-status" class="flex items-center space-x-2 text-sm">
<div class="w-2 h-2 bg-red-500 rounded-full"></div> <div class="w-2 h-2 bg-red-500 rounded-full"></div>
<span class="text-gray-600">Disconnected</span> <span class="text-gray-600">Disconnected</span>

View File

@@ -366,7 +366,7 @@ function renderLogs() {
logElement.className = `log-entry py-1 px-2 hover:bg-gray-800 rounded transition-colors duration-150 ${getLogLevelClass(log.level)}`; logElement.className = `log-entry py-1 px-2 hover:bg-gray-800 rounded transition-colors duration-150 ${getLogLevelClass(log.level)}`;
logElement.innerHTML = ` logElement.innerHTML = `
<div class="flex items-start gap-3 text-xs font-mono"> <div class="flex items-start gap-3 text-xs font-mono">
<span class="log-timestamp text-gray-500 flex-shrink-0 w-32">${escapeHtml(log.timestamp)}</span> <span class="log-timestamp text-gray-400 flex-shrink-0 w-32">${escapeHtml(log.timestamp)}</span>
<span class="log-level flex-shrink-0 px-2 py-0.5 rounded text-xs font-semibold ${getLogLevelBadgeClass(log.level)}">${log.level}</span> <span class="log-level flex-shrink-0 px-2 py-0.5 rounded text-xs font-semibold ${getLogLevelBadgeClass(log.level)}">${log.level}</span>
<span class="log-message flex-1 ${getLogLevelTextClass(log.level)} break-words">${escapeHtml(log.message)}</span> <span class="log-message flex-1 ${getLogLevelTextClass(log.level)} break-words">${escapeHtml(log.message)}</span>
</div> </div>