Fix odds and more (#81)

* fix(odds): Resolve incorrect sport and league parameters in _fetch_odds calls

- Fixed SportsCore._fetch_data() to call _fetch_odds(game) instead of _fetch_odds(game, sport_key, sport_key)
- Updated _fetch_odds method signature to accept only game parameter
- Added _fetch_odds_with_params helper method for sport-specific implementations
- Updated sport-specific managers to use correct sport and league parameters:
  - NFL: football/nfl
  - NCAA Football: football/college-football
  - NCAA Hockey: hockey/mens-college-hockey
- Ensures odds are fetched with correct ESPN API endpoints

Fixes #79

* Fix odds and other things

* update hockey

* fix rankings

* update imports

* Fix Logo Cache

* Add show_favorite_team_only attribute

---------

Co-authored-by: ChuckBuilds <33324927+ChuckBuilds@users.noreply.github.com>
Co-authored-by: Alex Resnick <adr8282@gmail.com>

src/ncaa_fb_managers.py

@@ -37,53 +37,11 @@ class BaseNCAAFBManager(Football): # Renamed class
         self.recent_enabled = display_modes.get("ncaa_fb_recent", False)
         self.upcoming_enabled = display_modes.get("ncaa_fb_upcoming", False)
         self.live_enabled = display_modes.get("ncaa_fb_live", False)
-
+        self.league = "college-football"
 
         self.logger.info(f"Initialized NCAAFB manager with display dimensions: {self.display_width}x{self.display_height}")
         self.logger.info(f"Logo directory: {self.logo_dir}")
         self.logger.info(f"Display modes - Recent: {self.recent_enabled}, Upcoming: {self.upcoming_enabled}, Live: {self.live_enabled}")
-    
-    def _fetch_team_rankings(self) -> Dict[str, int]:
-        """Fetch current team rankings from ESPN API."""
-        current_time = time.time()
-        
-        # Check if we have cached rankings that are still valid
-        if (self._team_rankings_cache and 
-            current_time - self._rankings_cache_timestamp < self._rankings_cache_duration):
-            return self._team_rankings_cache
-        
-        try:
-            rankings_url = "https://site.api.espn.com/apis/site/v2/sports/football/college-football/rankings"
-            response = self.session.get(rankings_url, headers=self.headers, timeout=30)
-            response.raise_for_status()
-            data = response.json()
-            
-            rankings = {}
-            rankings_data = data.get('rankings', [])
-            
-            if rankings_data:
-                # Use the first ranking (usually AP Top 25)
-                first_ranking = rankings_data[0]
-                teams = first_ranking.get('ranks', [])
-                
-                for team_data in teams:
-                    team_info = team_data.get('team', {})
-                    team_abbr = team_info.get('abbreviation', '')
-                    current_rank = team_data.get('current', 0)
-                    
-                    if team_abbr and current_rank > 0:
-                        rankings[team_abbr] = current_rank
-            
-            # Cache the results
-            self._team_rankings_cache = rankings
-            self._rankings_cache_timestamp = current_time
-            
-            self.logger.debug(f"Fetched rankings for {len(rankings)} teams")
-            return rankings
-            
-        except Exception as e:
-            self.logger.error(f"Error fetching team rankings: {e}")
-            return {}
 
     def _fetch_ncaa_fb_api_data(self, use_cache: bool = True) -> Optional[Dict]:
         """
@@ -159,7 +117,7 @@ class BaseNCAAFBManager(Football): # Renamed class
         self.background_fetch_requests[season_year] = request_id
         
         # For immediate response, try to get partial data
-        partial_data = self._get_weeks_data("college-football")
+        partial_data = self._get_weeks_data()
         if partial_data:
             return partial_data
         return None
@@ -191,14 +149,10 @@ class BaseNCAAFBManager(Football): # Renamed class
     def _fetch_data(self) -> Optional[Dict]:
         """Fetch data using shared data mechanism or direct fetch for live."""
         if isinstance(self, NCAAFBLiveManager):
-            return self._fetch_todays_games("college-football")
+            return self._fetch_todays_games()
         else:
             return self._fetch_ncaa_fb_api_data(use_cache=True)
 
-
-    def _fetch_football_odds(self, game: Dict) -> None:
-        super()._fetch_odds(game, "college-football")
-
 class NCAAFBLiveManager(BaseNCAAFBManager, FootballLive): # Renamed class
     """Manager for live NCAA FB games.""" # Updated docstring
     def __init__(self, config: Dict[str, Any], display_manager: DisplayManager, cache_manager: CacheManager):