feat(scroll): show which scroll speeds are smooth on this panel (#710)

* feat(scroll): show which scroll speeds are smooth on this panel The Vegas Scroll Speed slider now says what the panel will do with the chosen speed and offers the nearest smooth ones to click. Backed by scroll_config.speed_advice() and GET /api/v3/config/scroll-speed-advice, which uses the refresh the display measured rather than the cap. Also stops the default 50 px/s snapping to a stepped 48 px/s (2px every 5 refreshes, 24fps) on a 120Hz panel: the low-fps penalty in solve_crisp() now loses to 60 or 40 px/s. 100Hz panels are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(scroll): hint threw before its timer variables existed; count 25-30fps as stepped The Vegas speed hint called refreshScrollSpeedHint() before the let declarations it uses, so it never rendered (found on ledpi). And the solver's low-fps penalty stopped at 25fps, which let a measured 125.7Hz panel keep a 25.1fps 2px-every-5-refreshes scroll. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * test: add the scroll-speed-advice route to the /api/v3 URL map snapshot Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-04 14:25:08 +00:00 · 2026-10-01 14:15:22 -04:00
parent 4ddc3a3620
commit 16b566e14f
8 changed files with 285 additions and 4 deletions
@@ -0,0 +1,49 @@
+"""GET /api/v3/config/scroll-speed-advice: what the panel does with a speed."""
+import json
+from unittest.mock import MagicMock
+
+import pytest
+from flask import Flask
+
+from web_interface.blueprints.api_v3 import api_v3
+from web_interface.blueprints.api_v3 import config as config_routes
+
+
+@pytest.fixture
+def client(monkeypatch, tmp_path):
+    stats = tmp_path / "stats.json"
+    monkeypatch.setattr("src.common.frame_timing.default_stats_path", lambda: str(stats))
+    manager = MagicMock()
+    manager.load_config.return_value = {
+        "display": {"hardware": {"limit_refresh_rate_hz": 120}}}
+    monkeypatch.setattr(api_v3, "config_manager", manager, raising=False)
+    app = Flask(__name__)
+    app.register_blueprint(api_v3, url_prefix="/api/v3")
+    c = app.test_client()
+    c.stats_path = stats
+    return c
+
+
+def test_uses_the_configured_cap_without_a_measurement(client):
+    body = client.get("/api/v3/config/scroll-speed-advice?speed=50").get_json()
+    data = body["data"]
+    assert data["refresh_source"] == "configured"
+    assert data["refresh_hz"] == 120.0
+    assert [a["pixels_per_second"] for a in data["alternatives"]] == [40.0, 60.0]
+
+
+def test_prefers_the_measured_refresh(client):
+    client.stats_path.write_text(json.dumps({"measured_refresh_hz": 125.74}))
+    data = client.get("/api/v3/config/scroll-speed-advice?speed=50").get_json()["data"]
+    assert data["refresh_source"] == "measured"
+    assert data["refresh_hz"] == 125.7
+
+
+def test_ignores_an_implausible_stale_measurement(client):
+    client.stats_path.write_text(json.dumps({"measured_refresh_hz": 40.0}))
+    data = client.get("/api/v3/config/scroll-speed-advice?speed=50").get_json()["data"]
+    assert data["refresh_source"] == "configured"
+
+
+def test_rejects_a_non_numeric_speed(client):
+    assert client.get("/api/v3/config/scroll-speed-advice?speed=fast").status_code == 400