mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-05-26 05:53:33 +00:00
Fix broken logger format string and leaked exception in config save error
- pages_v3.py: plain string was used instead of %-style substitution,
so every manifest-read failure logged the literal "{plugin_id}"
- api_v3.py save_main_config: exception message was still leaking
through the error response; replace with generic message (consistent
with the rest of the CodeQL sweep in this PR)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1039,12 +1039,10 @@ def save_main_config():
|
||||
|
||||
return success_response(message='Configuration saved successfully')
|
||||
except Exception as e:
|
||||
import logging
|
||||
logger.error("Error saving config", exc_info=True)
|
||||
return error_response(
|
||||
ErrorCode.CONFIG_SAVE_FAILED,
|
||||
f"Error saving configuration: {e}",
|
||||
|
||||
"An error occurred; see logs for details",
|
||||
status_code=500
|
||||
)
|
||||
|
||||
|
||||
@@ -219,7 +219,7 @@ def _load_plugins_partial():
|
||||
plugin_info.update(fresh_manifest)
|
||||
except Exception as e:
|
||||
# If we can't read the fresh manifest, use the cached one
|
||||
logger.warning("Could not read fresh manifest for {plugin_id}")
|
||||
logger.warning("Could not read fresh manifest for plugin: %s", plugin_id)
|
||||
|
||||
# Get enabled status from config (source of truth)
|
||||
# Read from config file first, fall back to plugin instance if config doesn't have the key
|
||||
|
||||
Reference in New Issue
Block a user